Skip to content

Fix #157: Restore WAVES Fido client for SPDF data sources#158

Merged
samaloney merged 7 commits intosunpy:mainfrom
Amityush-lgtm:issue-157-restore-waves-client
Feb 23, 2026
Merged

Fix #157: Restore WAVES Fido client for SPDF data sources#158
samaloney merged 7 commits intosunpy:mainfrom
Amityush-lgtm:issue-157-restore-waves-client

Conversation

@Amityush-lgtm
Copy link
Copy Markdown
Contributor

@Amityush-lgtm Amityush-lgtm commented Feb 22, 2026

PR Description

Closes #157.

This PR restores the WIND/WAVES Fido client to fetch data from the updated SPDF directories specifically mentioned directories like rad1_idl_binary and rad2_idl_binary making Fido search and fetch work together with spectrogram.

What changed

  • Updated radiospectra/net/sources/wind.py to use the new SPDF dailyfile URL patterns (year subdirectories) for RAD1/RAD2.
  • Added _check_wavelengths logic to filter queries correctly for both receivers RAD1 and RAD2 based on frequency/wavelength overlap.
  • Added tests in radiospectra/net/sources/tests/test_wind_client.py.
  • Updates spectrogram_factory.py's _read_idl_sav method to correctly parse dates from prefixed filenames and added test.

AI Assistance Disclosure

AI tools were used for:

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding
  • No AI tools were used

AI was used to draft an initial version of the client changes and some unit tests i reviewed and edited all output and verified behavior via tests.

Regardless of AI use, the human contributor remains fully responsible for correctness, design choices, licensing compatibility, and long-term maintainability.

@samaloney, Let me know your thoughts on this. Happy to make changes!

@Amityush-lgtm Amityush-lgtm changed the title Fix #147: Restore WAVES Fido client for SPDF data sources Fix #157: Restore WAVES Fido client for SPDF data sources Feb 23, 2026
Copy link
Copy Markdown
Member

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good me!

@samaloney samaloney merged commit e9d493b into sunpy:main Feb 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore WAVES client and update source

2 participants